Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use FindPython #11

Merged
merged 7 commits into from
Sep 25, 2022
Merged

use FindPython #11

merged 7 commits into from
Sep 25, 2022

Conversation

maxbachmann
Copy link
Member

No description provided.

@henryiii
Copy link
Contributor

henryiii commented Sep 3, 2022

I've got RapidFuzz working to the point that Jarowinkler is the failure when testing. Same fixes here likely would help? rapidfuzz/RapidFuzz#256

@maxbachmann
Copy link
Member Author

maxbachmann commented Sep 9, 2022

@henryiii I did try to apply the same changes you added in the rapidfuzz PR.

There are a couple of issues:

  1. It does not install the so files when building for PyPy on all platforms: https://github.com/maxbachmann/JaroWinkler/runs/8279837877?check_suite_focus=true
  2. it doesn't find cython: https://github.com/maxbachmann/JaroWinkler/runs/8279891551?check_suite_focus=true

@maxbachmann
Copy link
Member Author

It appears to name the so file incorrectly:

copying _skbuild/linux-x86_64-3.9/setuptools/lib.linux-x86_64-pypy39/jarowinkler/_initialize_cpp.so -> _skbuild/linux-x86_64-3.9/setuptools/bdist.linux-x86_64/wheel/jarowinkler

this should be called _initialize_cpp.pypy39-pp73-x86_64-linux-gnu.so

@maxbachmann maxbachmann merged commit 86eae53 into main Sep 25, 2022
@maxbachmann maxbachmann deleted the FindPython branch September 27, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants