Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a minor bug which was causing loading twice #101

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

VibhuJawa
Copy link
Member

I noticed that we are loading model twice when running again on a new dataset. We should not do that. My hunch is this was caused due to dask serializing the class it on workers and causing it to create a new id for it

This PR changes that by caching the ID on initialization, which i tested and that works.

Copy link

copy-pr-bot bot commented Nov 14, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@VibhuJawa VibhuJawa marked this pull request as ready for review November 14, 2024 12:28
@VibhuJawa
Copy link
Member Author

/okay to test

Copy link
Collaborator

@sarahyurick sarahyurick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@VibhuJawa VibhuJawa merged commit e009be2 into rapidsai:main Nov 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants