Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build instructions in README.md #61

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

VibhuJawa
Copy link
Member

No description provided.

@VibhuJawa VibhuJawa requested a review from sarahyurick July 19, 2024 23:32
To contribute to this library, first create a conda environment with the necessary dependencies:
```
cd crossfit
mamba env create -f conda/environments/cuda_dev.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When trying to create the environment I'm getting the following error:

(base) syurick@ipp1-3303:~/scratch/crossfit$ mamba env create -f conda/environments/cuda_dev.yaml
conda-forge/linux-64                                        Using cache
conda-forge/noarch                                          Using cache
nvidia/linux-64                                             Using cache
nvidia/noarch                                               Using cache
pkgs/r/linux-64                                               No change
pkgs/main/linux-64                                            No change
pkgs/main/noarch                                              No change
pkgs/r/noarch                                                 No change
rapidsai/linux-64                                             No change
rapidsai/noarch                                               No change


Looking for: ['bandit', 'black', 'cuda-version=12.0', "cudf[version='>=24.4']", "cuml[version='>=24.4']", "cupy[version='>=12.0.0']", 'dev', "dask-cuda[version='>=24.4']", "dask-cudf[version='>=24.4']", 'flake8', 'isort', 'pip', "pylibraft[version='>=24.4']", 'pytest', 'pytest-benchmark', "pytest-cov[version='>=2']", "pytorch[version='>=2.0']", 'transformers', 'tokenizers', 'torchvision', "scikit-learn[version='>=0.23.1']", 'scipy', "setuptools[version='>=61.0.0']", 'sentence-transformers', 'pip==-=pytrec_eval']


Encountered problems while solving:
  - nothing provides requested dev
  - nothing provides requested pip ==- pytrec_eval

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be resolved now: 18fe8b2, tested it locally

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, works now!

@VibhuJawa VibhuJawa self-assigned this Aug 5, 2024
@VibhuJawa VibhuJawa marked this pull request as draft August 5, 2024 05:06
Signed-off-by: Vibhu Jawa <vibhujawa@gmail.com>
@VibhuJawa VibhuJawa marked this pull request as ready for review August 6, 2024 00:29
Copy link
Collaborator

@sarahyurick sarahyurick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

To contribute to this library, first create a conda environment with the necessary dependencies:
```
cd crossfit
mamba env create -f conda/environments/cuda_dev.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, works now!

@VibhuJawa VibhuJawa merged commit 384f3cf into rapidsai:main Aug 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants