Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Pandas Series to cuDF Series #76

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Convert Pandas Series to cuDF Series #76

merged 2 commits into from
Aug 13, 2024

Conversation

sarahyurick
Copy link
Collaborator

Closes #70

cc @VibhuJawa

@sarahyurick
Copy link
Collaborator Author

Hi @VibhuJawa this is ready for review.

I tried calling to_backend("cudf") as you suggested here but it wasn't fixing the error message I was getting. This PR allows this notebook to work on a CPU Dask DataFrame, though.

@sarahyurick sarahyurick requested a review from VibhuJawa August 13, 2024 20:20
VibhuJawa
VibhuJawa reviewed Aug 13, 2024
View reviewed changes
crossfit/op/tokenize.py Outdated Show resolved Hide resolved
VibhuJawa
VibhuJawa requested changes Aug 13, 2024
View reviewed changes
Copy link
Member

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a change, we can probably live in pd.Series. Can we also add a test for the PR.

Thanks for working on this @sarahyurick .

@sarahyurick sarahyurick mentioned this pull request Aug 13, 2024
Open
sarahyurick
sarahyurick commented Aug 13, 2024
View reviewed changes
Copy link
Collaborator Author

@sarahyurick sarahyurick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @VibhuJawa ! Updated.

tests/op/test_tokenize.py Show resolved Hide resolved
VibhuJawa
VibhuJawa approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this @sarahyurick

@VibhuJawa VibhuJawa merged commit 9e52a90 into rapidsai:main Aug 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VibhuJawa VibhuJawa VibhuJawa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more flexible CPU/GPU support
2 participants
@sarahyurick @VibhuJawa