Skip to content

Commit

Permalink
Fix call to deprecated factory function (#14695)
Browse files Browse the repository at this point in the history
A call to a deprecated `cudf::make_strings_column` factory function was introduced in #14664.
This call had been previously fixed in #14461 but was lost when the source file was moved in #14664.

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Nghia Truong (https://github.com/ttnghia)

URL: #14695
  • Loading branch information
davidwendt authored Jan 4, 2024
1 parent a9ca11f commit 4c01e95
Showing 1 changed file with 10 additions and 7 deletions.
17 changes: 10 additions & 7 deletions cpp/src/transform/row_conversion.cu
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2020-2023, NVIDIA CORPORATION.
* Copyright (c) 2020-2024, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -2506,12 +2506,15 @@ std::unique_ptr<table> convert_from_rows(lists_column_view const& input,
for (int i = 0; i < static_cast<int>(schema.size()); ++i) {
if (schema[i].id() == type_id::STRING) {
// stuff real string column
auto string_data = string_row_offset_columns[string_idx].release()->release();
output_columns[i] = make_strings_column(num_rows,
std::move(string_col_offsets[string_idx]),
std::move(string_data_cols[string_idx]),
std::move(*string_data.null_mask.release()),
0);
auto string_data = string_row_offset_columns[string_idx].release()->release();
output_columns[i] =
make_strings_column(num_rows,
std::make_unique<cudf::column>(
std::move(string_col_offsets[string_idx]), rmm::device_buffer{}, 0),
std::make_unique<cudf::column>(
std::move(string_data_cols[string_idx]), rmm::device_buffer{}, 0),
0,
std::move(*string_data.null_mask.release()));
// Null count set to 0, temporarily. Will be fixed up before return.
string_idx++;
}
Expand Down

0 comments on commit 4c01e95

Please sign in to comment.