Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] JNI bindings for maps_column_view::get_value_for(column_view) #10818

Closed
mythrocks opened this issue May 10, 2022 · 1 comment · Fixed by #11104
Closed

[FEA] JNI bindings for maps_column_view::get_value_for(column_view) #10818

mythrocks opened this issue May 10, 2022 · 1 comment · Fixed by #11104
Assignees
@razajafri
Labels
feature request New feature or request

Comments

@mythrocks
Copy link
Contributor

#10380 introduced a maps_column_view abstraction to interpret LIST<STRUCT<key,value>> columns as maps, and look up values corresponding to keys specified either as scalars or columns.

However, the JNI layer currently supports ColumnView::getMapValue() using only Scalar keys. To support key lookup using per-row expression values, one would need a ColumnView::getMapValueFromKeyVector() that takes a ColumnView. This is required to support queries like those specified in NVIDIA/spark-rapids#5204.

Note that the heavy lifting is already done in the native code, i.e. maps_column_view::get_value_for(column_view). All that is required is the JNI plumbing to patch through to maps_column_view.
@mythrocks mythrocks added feature request New feature or request Needs Triage Need team to review and classify labels May 10, 2022
@mythrocks mythrocks self-assigned this May 10, 2022
@mythrocks mythrocks assigned rwlee and unassigned mythrocks May 10, 2022
@mythrocks
Copy link
Contributor Author

Note: This issue is specifically for get_value_for(). Similar work for maps_column_view::contains(column_view keys) may be pursued in a separate issue.

@razajafri razajafri assigned razajafri and unassigned rwlee May 20, 2022
@razajafri razajafri mentioned this issue Jun 14, 2022
Merged
rapids-bot bot pushed a commit that referenced this issue Jun 16, 2022
@razajafri
Added JNI for getMapValueForKeys (#11104)
ef6a390 
This PR adds Java method for getting values for a list of keys

fixes #10818

Authors:
  - Raza Jafri (https://github.com/razajafri)

Approvers:
  - Robert (Bobby) Evans (https://github.com/revans2)

URL: #11104
@bdice bdice removed the Needs Triage Need team to review and classify label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@razajafri razajafri

Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Java] Added JNI for getMapValueForKeys razajafri/cudf
4 participants
@bdice @mythrocks @razajafri @rwlee