Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Add Java support for extract_all_record #11033

Closed
anthony-chang opened this issue Jun 2, 2022 · 0 comments · Fixed by #11215
Closed

[FEA] Add Java support for extract_all_record #11033

anthony-chang opened this issue Jun 2, 2022 · 0 comments · Fixed by #11215
Labels
feature request New feature or request Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS

Comments

@anthony-chang
Copy link
Contributor

Is your feature request related to a problem? Please describe.
cuDF cpp already has an implementation for cudf::strings::extract_all_record but no Java API. I would like to expose this to support Spark's function regexp_extract_all.

Describe the solution you'd like
Add JNI bindings for cudf::strings::extract_all_record

Describe alternatives you've considered
None

Additional context
None
@anthony-chang anthony-chang added Needs Triage Need team to review and classify feature request New feature or request labels Jun 2, 2022
@sameerz sameerz mentioned this issue Jun 22, 2022
Closed
@GregoryKimball GregoryKimball added Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS and removed Needs Triage Need team to review and classify labels Jun 29, 2022
@anthony-chang anthony-chang mentioned this issue Jul 5, 2022
Merged
rapids-bot bot pushed a commit that referenced this issue Jul 6, 2022
@anthony-chang
Add JNI bindings for extractAllRecord (#11196)
fd3cf3e 
Part of #11033

Adds `extractAllRecord` to the JNI layer. For now this only supports `idx` 0 using `cudf::strings::findall_record`. 

Corresponding spark plugin PR: NVIDIA/spark-rapids#5947

Authors:
  - Anthony Chang (https://github.com/anthony-chang)

Approvers:
  - Robert (Bobby) Evans (https://github.com/revans2)

URL: #11196
@anthony-chang anthony-chang mentioned this issue Jul 7, 2022
Merged
rapids-bot bot pushed a commit that referenced this issue Jul 8, 2022
@anthony-chang
Enable positive group indices for extractAllRecord on JNI (#11215)
1331994 
Closes #11033

Allow `extractAllRecord` to take an `idx` > 0 and exposes `cudf::strings::extract_all_record`

Authors:
  - Anthony Chang (https://github.com/anthony-chang)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - MithunR (https://github.com/mythrocks)
  - Alessandro Bellina (https://github.com/abellina)
  - Robert (Bobby) Evans (https://github.com/revans2)

URL: #11215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable positive group indices for extractAllRecord on JNI anthony-chang/cudf
2 participants
@GregoryKimball @anthony-chang