-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Logical and
(&&) and or
(||) support.
#1517
Comments
Hey @harrism , you're definitely technically correct when you say those are bitwise operators and that we should use logical operators instead, but just to provide context here, the reason those other issues request bitwise operators instead of the logical operators |
It looks like in Pandas |
Regardless of how the Python side chooses to expose them, we don't have the logical operators in libcudf today. |
This can be added pretty quickly in JIT code. The python side might take some time. |
Is your feature request related to a problem? Please describe.
Add C++
&&
and||
binary operators to libcudf, and Pythonand
andor
binary operators to cudfDescribe the solution you'd like
Support performing logical operators between Series / columns
Additional context
#1142 adds a first-class Boolean type, so this functionality makes more sense now.
#1071 requested binary
&
and|
but refers to them as "logical" operators, when they are actually bitwise operators. The bitwise operators have been implemented.#49 appears to have requested this feature, but it was also interpreted as requesting bitwise operators.
The text was updated successfully, but these errors were encountered: