[REVIEW] Add GDF_BOOL type #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhemstad
added
2 - In Progress
…ithmetic wrapper operator tests to cast to original type.
…are adequate and passing for these types.
harrism
added
3 - Ready for Review
|
@jrhemstad This is ready for review, but I can't request that you review it since you originally started the PR! |
|
I realized I didn't overload any comparison operators except ==, which can't be right... so that means the tests are also insufficient. Still a bit to do here. |
kovaltan
reviewed
Apr 18, 2019
kovaltan
reviewed
Apr 25, 2019
kovaltan
previously requested changes
Apr 25, 2019
This was referenced Apr 29, 2019
|
@harrism since it's my own PR, I can't "Approve" formally, so I'll say that all the changes look good. |
harrism
dismissed
kovaltan’s stale review
@kovaltan is on vacation and his suggestion is resolved.
harrism
approved these changes
Apr 29, 2019
|
@jrhemstad : 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #817
GDF_BOOL8gdf_dtype andgdf_bool8storage type.cudf::bool8wrapper (cannot redefineboolin a namespace,8indicates an 8-bit representation)type_dispatchergdf_dtype_ofwrappertestswrapperoperators forbool8convertStrToValuehttps://github.com/rapidsai/cudf/blob/branch-0.6/cpp/src/io/csv/type_conversion.cuh#L256std::numeric_limitsforcudf::bool8operator++/operator--).This PR does NOT address testing / supporting of GDF_BOOL8 in the following modules. Testing of these should be added in another PR: atomics, binary and unary operations, order_by, group_by, join, hashing, replace, quantiles, CSV, Parquet, and any other file loaders. Issue #1518 filed to cover this.
I (@harrism) tried to add cudf::bool8 as a tested type to orderby, but ran into failures because the reference solution assumes integer arithmetic/comparison semantics rather than Boolean semantics. Therefore I decided that testing support for BOOL8 everywhere is too large a task for this PR.
Closes #667