You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
I'm about to undertake yet another change to every function in libcudf that takes an MR parameter. To prevent doing this too many times in the future, I would like to provide a wrapper in libcudf to centralize calls to rmm::get_current_device_resource[_ref]() and an alias for RMM resource_ref type. hopefully this can reduce the number of files that need to change in the future when this functionality changes (e.g. if it moves out of RMM to CCCL).
Describe the solution you'd like
A header, say cpp/include/cudf/utilities/memory_resource.hpp. Please provide suggestions on the best place for this. Contents something like this:
Merge after rapidsai/rmm#1661
Creates and uses CUDF internal wrappers around RMM `current_device_resource` functions.
I've marked this PR as breaking because it breaks the ABI, however the API is compatible.
For reviewers, the most substantial additions are in the new file `<cudf/utilities/memory_resource.hpp>`, and in the `DEVELOPER_GUIDE.md` and `*.rst` docs. The rest are all replacements of an include and all calls to `rmm::get_current_device_resource()` with `cudf::get_current_device_resource_ref()`.
Closes#16676
Authors:
- Mark Harris (https://github.com/harrism)
Approvers:
- Nghia Truong (https://github.com/ttnghia)
- GALI PREM SAGAR (https://github.com/galipremsagar)
- https://github.com/nvdbaranec
- David Wendt (https://github.com/davidwendt)
URL: #16679
Is your feature request related to a problem? Please describe.
I'm about to undertake yet another change to every function in libcudf that takes an MR parameter. To prevent doing this too many times in the future, I would like to provide a wrapper in libcudf to centralize calls to
rmm::get_current_device_resource[_ref]()
and an alias for RMMresource_ref
type. hopefully this can reduce the number of files that need to change in the future when this functionality changes (e.g. if it moves out of RMM to CCCL).Describe the solution you'd like
A header, say
cpp/include/cudf/utilities/memory_resource.hpp
. Please provide suggestions on the best place for this. Contents something like this:Describe alternatives you've considered
Additional context
rapidsai/rmm#1598
The text was updated successfully, but these errors were encountered: