Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings in test_datetime.py #12381

Merged
merged 6 commits into from
Dec 15, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Dec 14, 2022

Description

Contributes to #9999 and #10363.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added 3 - Ready for Review Ready for review by team tests Unit testing for project code quality Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 14, 2022
@vyasr vyasr requested a review from a team as a code owner December 14, 2022 00:14
@vyasr vyasr self-assigned this Dec 14, 2022
Copy link
Contributor

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a pandas-compat side

@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Base: 86.58% // Head: 85.76% // Decreases project coverage by -0.81% ⚠️

Coverage data is based on head (5ef3156) compared to base (b6dccb3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-23.02   #12381      +/-   ##
================================================
- Coverage         86.58%   85.76%   -0.82%     
================================================
  Files               155      155              
  Lines             24368    24798     +430     
================================================
+ Hits              21098    21269     +171     
- Misses             3270     3529     +259     
Impacted Files Coverage Δ
python/cudf/cudf/_version.py 1.41% <0.00%> (-98.59%) ⬇️
python/cudf/cudf/core/buffer/spill_manager.py 74.37% <0.00%> (-5.63%) ⬇️
python/cudf/cudf/utils/dtypes.py 77.77% <0.00%> (-1.69%) ⬇️
python/cudf/cudf/options.py 86.11% <0.00%> (-1.59%) ⬇️
python/cudf/cudf/core/single_column_frame.py 94.30% <0.00%> (-1.27%) ⬇️
python/dask_cudf/dask_cudf/io/parquet.py 91.81% <0.00%> (-0.59%) ⬇️
python/cudf/cudf/core/multiindex.py 91.66% <0.00%> (-0.51%) ⬇️
python/cudf/cudf/core/algorithms.py 90.00% <0.00%> (-0.48%) ⬇️
python/cudf/cudf/core/dataframe.py 93.50% <0.00%> (-0.09%) ⬇️
python/cudf/cudf/core/join/_join_helpers.py 98.52% <0.00%> (-0.07%) ⬇️
... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vyasr
Copy link
Contributor Author

vyasr commented Dec 15, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8f975d6 into rapidsai:branch-23.02 Dec 15, 2022
@vyasr vyasr deleted the fix/datetime_warnings branch December 16, 2022 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API. tests Unit testing for project
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants