-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Drop names
, dtype
in Index.copy
and dtype
, levels
, codes
in MultiIndex.copy
#12898
[REVIEW] Drop names
, dtype
in Index.copy
and dtype
, levels
, codes
in MultiIndex.copy
#12898
Conversation
Looks like there are bunch of further tests that need cleanup
|
Right, but those are unrelated to this PR. We are basically aiming for the final PR from the feature branch to |
Ah, OK. thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question this PR title says we're dropping the names
and dtype
kwargs for Index.copy
but I also see changes dropping levels
and codes
from MultiIndex.copy
, is this as intended?
names
& dtype
in Index.copy
names
, dtype
in Index.copy
and levels
, codes
in MultiIndex.copy
Yup, it was intentional. I Updated the PR title. |
names
, dtype
in Index.copy
and levels
, codes
in MultiIndex.copy
names
, dtype
in Index.copy
and dtype
, levels
, codes
in MultiIndex.copy
Description
This PR removes
dtype
inIndex & MultiIndex
.copy
, andnames
inIndex.copy
Checklist