Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Bitwise binary ops AND, OR, XOR (&, |, ^) #1292

Merged
merged 12 commits into from
Mar 28, 2019
Merged

[REVIEW] Bitwise binary ops AND, OR, XOR (&, |, ^) #1292

merged 12 commits into from
Mar 28, 2019

Conversation

devavret
Copy link
Contributor

@devavret devavret commented Mar 26, 2019 •
edited
Loading

Adds JIT compiled bitwise binary ops
Resolves #49

  • libcudf
    • Jit functions
    • gtests
  • cuDF
    • Cython bindings
    • series.__and__, series.__or__, series.__xor__
    • dataframe.__and__, dataframe.__or__, dataframe.__xor__
    • index.__and__, index.__or__, index.__xor__
    • pytests

@devavret devavret mentioned this pull request Mar 27, 2019
Closed
@devavret devavret changed the title [WIP] Bitwise binary ops AND, OR, XOR (&, |, ^) [REVIEW] Bitwise binary ops AND, OR, XOR (&, |, ^) Mar 27, 2019
thomcom
thomcom reviewed Mar 27, 2019
View reviewed changes
python/cudf/dataframe/series.py Outdated Show resolved Hide resolved
python/cudf/dataframe/dataframe.py Show resolved Hide resolved
python/cudf/dataframe/dataframe.py Show resolved Hide resolved
@harrism harrism added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. labels Mar 28, 2019
harrism
harrism approved these changes Mar 28, 2019
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks.

@harrism harrism merged commit 6e0fdc7 into rapidsai:branch-0.7 Mar 28, 2019
@jcrist jcrist mentioned this pull request Apr 2, 2019
Closed
4 tasks
@bdice bdice mentioned this pull request Jan 31, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcom thomcom thomcom left review comments

@harrism harrism harrism approved these changes

Assignees

@devavret devavret

Labels
3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support more series operators
3 participants
@devavret @thomcom @harrism