Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Drop na_sentinel from factorize #12924

Merged
merged 1 commit into from
Mar 13, 2023
Merged

[REVIEW] Drop na_sentinel from factorize #12924

merged 1 commit into from
Mar 13, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

This PR drops support for na_sentinel in factorize APIs, to match with pandas-2.0

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function breaking Breaking change labels Mar 10, 2023
@galipremsagar galipremsagar self-assigned this Mar 10, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner March 10, 2023 20:13
@galipremsagar galipremsagar requested review from bdice and isVoid and removed request for a team March 10, 2023 20:13
@galipremsagar galipremsagar mentioned this pull request Mar 10, 2023
Closed
@github-actions github-actions bot added the Python Affects Python cuDF API. label Mar 10, 2023
@galipremsagar galipremsagar merged commit 4a87cbd into rapidsai:pandas_2.0_feature_branch Mar 13, 2023
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change improvement Improvement / enhancement to an existing function Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galipremsagar @mroeschke