Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log cuIO warnings using the libcudf logger #13043

Merged
merged 6 commits into from
Apr 4, 2023
Merged

Log cuIO warnings using the libcudf logger #13043

merged 6 commits into from
Apr 4, 2023

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Mar 30, 2023 •
edited
Loading

Description

Log warning messages in the following scenarios:

  • cuIO reader benchmark is ran without dropping the L3 cache.
  • An nvCOMP call fails and we fall back to older API.
  • Mangling of duplicated column names is disabled and some columns are dropped.
  • Default compression fails in ORC writer and we fall back to uncompressed output.
  • Parquet writer is writing a decimal column with precision < 10 as int64.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Mar 30, 2023
@vuule vuule added feature request New feature or request non-breaking Non-breaking change cuIO cuIO issue labels Mar 30, 2023
@vuule vuule mentioned this pull request Apr 3, 2023
Closed
@vuule vuule self-assigned this Apr 3, 2023
@vuule vuule marked this pull request as ready for review April 3, 2023 15:33
@vuule vuule requested a review from a team as a code owner April 3, 2023 15:33
@vuule vuule requested review from harrism and mythrocks April 3, 2023 15:33
harrism
harrism approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest removing word "Error" from warning messages, otherwise looks good.

cpp/src/io/comp/nvcomp_adapter.cpp Outdated Show resolved Hide resolved
cpp/src/io/orc/stripe_enc.cu Outdated Show resolved Hide resolved
vuule and others added 3 commits April 3, 2023 18:40
@vuule @harrism
avoid word "error" in warning messages
3b67af7 
Co-authored-by: Mark Harris <783069+harrism@users.noreply.github.com>
@vuule @harrism
same
1516851 
Co-authored-by: Mark Harris <783069+harrism@users.noreply.github.com>
@vuule
Merge branch 'branch-23.06' into log-io-warn
5ef819b
@vuule
Copy link
Contributor Author

vuule commented Apr 4, 2023

/merge

@rapids-bot rapids-bot bot merged commit bd1ef29 into rapidsai:branch-23.06 Apr 4, 2023
@vuule vuule deleted the log-io-warn branch April 4, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@ttnghia ttnghia ttnghia approved these changes

@mythrocks mythrocks Awaiting requested review from mythrocks mythrocks is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vuule vuule

Labels
cuIO cuIO issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vuule @harrism @ttnghia