Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Java bindings for string literal support in AST #13072

Merged
merged 19 commits into from
Apr 25, 2023
Merged

Add Java bindings for string literal support in AST #13072

merged 19 commits into from
Apr 25, 2023

Conversation

karthikeyann
Copy link
Contributor

Description

Depends on #13061
Add Java bindings for string scalar support in AST
Add unit test for string comparison - column vs column, column vs literal.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@karthikeyann karthikeyann added feature request New feature or request 3 - Ready for Review Ready for review by team Java Affects Java cuDF API. 4 - Needs cuDF (Java) Reviewer non-breaking Non-breaking change labels Apr 5, 2023
@karthikeyann karthikeyann self-assigned this Apr 5, 2023
@karthikeyann karthikeyann requested review from a team as code owners April 5, 2023 21:10
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Apr 5, 2023
@karthikeyann karthikeyann requested a review from a team as a code owner April 18, 2023 15:29
@github-actions github-actions bot added the Python Affects Python cuDF API. label Apr 18, 2023
@karthikeyann karthikeyann requested a review from jlowe April 20, 2023 13:38
@jlowe jlowe mentioned this pull request Apr 20, 2023
Closed
@karthikeyann karthikeyann requested review from a team and removed request for a team April 21, 2023 10:58
mythrocks
mythrocks approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. LGTM!

@karthikeyann
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 6ebdce9 into rapidsai:branch-23.06 Apr 25, 2023
@winningsix winningsix mentioned this pull request Nov 6, 2023
Merged
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

@mythrocks mythrocks mythrocks approved these changes

@hyperbolic2346 hyperbolic2346 Awaiting requested review from hyperbolic2346 hyperbolic2346 was automatically assigned from rapidsai/cudf-cpp-codeowners

@wence- wence- Awaiting requested review from wence- wence- was automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca was automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@karthikeyann karthikeyann

Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond feature request New feature or request Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karthikeyann @jlowe @mythrocks @vyasr