Cleanup Parquet chunked writer #13094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttnghia
added
3 - Ready for Review
Comment on lines
-225
to
-234
| Compression compression_ = Compression::UNCOMPRESSED; | ||
| size_t max_row_group_size = default_row_group_size_bytes; | ||
| size_type max_row_group_rows = default_row_group_size_rows; | ||
| size_t max_page_size_bytes = default_max_page_size_bytes; | ||
| size_type max_page_size_rows = default_max_page_size_rows; | ||
| statistics_freq stats_granularity_ = statistics_freq::STATISTICS_NONE; | ||
| dictionary_policy dict_policy_ = dictionary_policy::ALWAYS; | ||
| size_t max_dictionary_size_ = default_max_dictionary_size; | ||
| bool int96_timestamps = false; | ||
| int32_t column_index_truncate_length = default_column_index_truncate_length; |
There was a problem hiding this comment.
are these defaults defined again in writer options?
There was a problem hiding this comment.
These variables are assigned from outside options passed in by user, and never changed after the writer was constructed. Thus we don't need such default values here. These default values are used for writer options construction.
There was a problem hiding this comment.
hyperbolic2346
approved these changes
Apr 11, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #13091, this changes the internal variables of Parquet chunked writer:
_prefix consistently.constqualifier to some variables that are writer parameters.There is not any new implementation added. However, the unused parameter
mris removed from its interface thus this is flagged as breaking changes.Closes:
cudf::io::detail::parquet::writer::impl#13079