Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes sliced list and struct column bug in JSON chunked writer #13108

Merged
merged 4 commits into from
Apr 11, 2023
Merged

Fixes sliced list and struct column bug in JSON chunked writer #13108

merged 4 commits into from
Apr 11, 2023

Conversation

karthikeyann
Copy link
Contributor

Description

Fixes the OOM access error while using chunked JSON writer on list columns.
The issue is present in struct columns also, which is fixed in this change.
Fixes #13030

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@karthikeyann karthikeyann added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. 4 - Needs Review Waiting for reviewer to review or respond 4 - Needs cuIO Reviewer non-breaking Non-breaking change labels Apr 10, 2023
@karthikeyann karthikeyann requested a review from a team as a code owner April 10, 2023 19:11
@karthikeyann karthikeyann self-assigned this Apr 10, 2023
@karthikeyann karthikeyann added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond 4 - Needs cuIO Reviewer labels Apr 11, 2023
@karthikeyann
Copy link
Contributor Author

\merge

@karthikeyann
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5638d44 into rapidsai:branch-23.06 Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@davidwendt davidwendt davidwendt approved these changes

@hyperbolic2346 hyperbolic2346 Awaiting requested review from hyperbolic2346 hyperbolic2346 is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@divyegala divyegala Awaiting requested review from divyegala divyegala is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@karthikeyann karthikeyann

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] cudaErrorIllegalAddress when trying to write a large list column to json
4 participants
@karthikeyann @ttnghia @davidwendt @galipremsagar