Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ifdefs around nvcc-specific pragmas #13110

Merged
merged 4 commits into from
Apr 11, 2023

Conversation

hyperbolic2346
Copy link
Contributor

Description

This change wraps the NVCC-specific #pragma macros inside an ifdef to prevent compilation warnings as described in issue #13106

closes #13106

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@hyperbolic2346 hyperbolic2346 added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. tech debt non-breaking Non-breaking change labels Apr 10, 2023
@hyperbolic2346 hyperbolic2346 requested a review from a team as a code owner April 10, 2023 23:56
@hyperbolic2346 hyperbolic2346 self-assigned this Apr 10, 2023
@hyperbolic2346
Copy link
Contributor Author

I thought about making a macro for this, but it seemed like this didn't hit the threshold of change required to warrant it.

@hyperbolic2346 hyperbolic2346 added code quality improvement Improvement / enhancement to an existing function labels Apr 10, 2023
@bdice
Copy link
Contributor

bdice commented Apr 11, 2023

I thought about making a macro for this, but it seemed like this didn't hit the threshold of change required to warrant it.

Agreed. I support what you did here.

@hyperbolic2346
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit e9e86f4 into rapidsai:branch-23.06 Apr 11, 2023
@hyperbolic2346 hyperbolic2346 deleted the mwilson/13106 branch April 11, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Wrap #pragma nv_* in macro that is enabled only for nvcc
3 participants