Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GPU_ARCHS setting in Java CMake build and CMAKE_CUDA_ARCHITECTURES in Python package build. #13117

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Apr 11, 2023

Description

Changes the GPU_ARCHS setting in pom.xml from ALL to RAPIDS per recent change in rapidsai/rapids-cmake/pull/397

The Python package build requires CUDA as of the addition of string UDFs, which added compilation of ptx code to the Python build. Therefore CMAKE_CUDA_ARCHITECTURES must be set appropriately even when only the Python package is being built. rapidsai/rapids-cmake#397 requires a nonempty string value to be used if the variable is set at all. This PR updates build.sh to include the appropriate default when only the Python build is requested.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team Java Affects Java cuDF API. non-breaking Non-breaking change labels Apr 11, 2023
@davidwendt davidwendt requested a review from a team as a code owner April 11, 2023 16:50
@davidwendt davidwendt self-assigned this Apr 11, 2023
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving, but let's mention Python / cudf in the PR title rather than only Java. edit: Done.

@bdice bdice changed the title Fix GPU_ARCHS setting in java cmake build Fix GPU_ARCHS setting in Java CMake build and CMAKE_CUDA_ARCHITECTURES in Python package build. Apr 11, 2023
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 50718e6 into rapidsai:branch-23.06 Apr 11, 2023
@davidwendt davidwendt deleted the fix-java-cmake branch April 11, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants