Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CTAD instead of functions in ProtobufReader #13135

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Use CTAD instead of functions in ProtobufReader #13135

merged 1 commit into from
Apr 14, 2023

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Apr 13, 2023

Description

Replaced std::make_tuple with std::tuple constructor
Removed std::make_field_reader, calling field_reader constructor directly now.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vuule vuule self-assigned this Apr 13, 2023
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Apr 13, 2023
@vuule vuule added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change cuIO cuIO issue labels Apr 13, 2023
@vuule vuule marked this pull request as ready for review April 13, 2023 22:00
@vuule vuule requested a review from a team as a code owner April 13, 2023 22:00
@vuule vuule requested review from vyasr and bdice April 13, 2023 22:00
@vuule
Copy link
Contributor Author

vuule commented Apr 14, 2023

/merge

@rapids-bot rapids-bot bot merged commit a562a7e into rapidsai:branch-23.06 Apr 14, 2023
@vuule vuule deleted the cleanup-replace-functions-with-ctad branch April 14, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vuule vuule

Labels
cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vuule @vyasr @ttnghia