Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix libcudf to always pass null-count to set_null_mask #13149

Merged
merged 7 commits into from
Apr 20, 2023
Merged

Fix libcudf to always pass null-count to set_null_mask #13149

merged 7 commits into from
Apr 20, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Fix calls to the column::set_null_mask() function to always pass the null-count value in libcudf source files.

Contributes to: #11968

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 17, 2023
@davidwendt davidwendt self-assigned this Apr 17, 2023
@davidwendt davidwendt mentioned this pull request Apr 17, 2023
Merged
3 tasks
@davidwendt davidwendt added the 3 - Ready for Review Ready for review by team label Apr 18, 2023
rapids-bot bot pushed a commit that referenced this pull request Apr 19, 2023
@davidwendt
Change some .cu gtest files to .cpp (#13155)
4f85f63 
Changed some libcudf gtests source files from .cu to .cpp by removing the unneeded thrust calls. This also simplified the logic a bit as well.
These were found while working on #13149

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Robert Maynard (https://github.com/robertmaynard)
  - https://github.com/nvdbaranec

URL: #13155
@davidwendt davidwendt removed the 2 - In Progress Currently a work in progress label Apr 19, 2023
@davidwendt davidwendt marked this pull request as ready for review April 19, 2023 12:56
@davidwendt davidwendt requested a review from a team as a code owner April 19, 2023 12:56
vyasr
vyasr approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, but this is good to merge once that is resolved. Thanks!

cpp/src/groupby/sort/group_rank_scan.cu Show resolved Hide resolved
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 9d36716 into rapidsai:branch-23.06 Apr 20, 2023
@davidwendt davidwendt deleted the set-null-mask-count branch April 20, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@harrism harrism harrism approved these changes

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidwendt @harrism @vyasr @ttnghia