-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Add no_default
and adapt Series.reset_index
to differentiate None
for name
parameter
#13152
[REVIEW] Add no_default
and adapt Series.reset_index
to differentiate None
for name
parameter
#13152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's match the pandas API layout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add tests for the cases newly supported by this PR (None
names)?
|
Sorry, I misread the filename and thought that was an implementation and not a test. My mistake. Approving now! |
Description
In
pandas-2.0
the behavior forname
parameter has changed to actually name a column0
if no value is passed toname
. But ifname=None
, the column will be namedNone
too:To achieve the same behavior in
cudf
, we had to introduceno_default
value(which is same as pandas'sno_default
value).This also fixes 18 pytests:
On
pandas_2.0_feature_branch
:Checklist