Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split up unique_count.cu to improve build time #13169

Merged
merged 10 commits into from
Apr 25, 2023
Merged

Split up unique_count.cu to improve build time #13169

merged 10 commits into from
Apr 25, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Moves the column_view overload out of cpp/src/stream_compaction/unique_count.cu and into the new file cpp/src/stream_compaction/unique_count_column.cu to help improve overall build time.
Compiling these two in parallel roughly speeds up their build time by 2x.
The unique_count.cu is one of the files that takes over 20 minutes to build in CI.
Also cleaned up much of the include statements.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 19, 2023
@davidwendt davidwendt self-assigned this Apr 19, 2023
@github-actions github-actions bot added the CMake CMake build issue label Apr 19, 2023
davidwendt
davidwendt commented Apr 19, 2023
View reviewed changes
cpp/src/stream_compaction/unique_count_column.cu
@@ -0,0 +1,110 @@
/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code moved from unique_count.cu

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Apr 19, 2023
@davidwendt
Copy link
Contributor Author

Each one now takes less than 10 minutes: https://downloads.rapids.ai/ci/cudf/pull-request/13169/abc1d0b/cuda11_x86_64.ninja_log.html

@davidwendt davidwendt marked this pull request as ready for review April 19, 2023 18:40
@davidwendt davidwendt requested review from a team as code owners April 19, 2023 18:40
@ttnghia
Copy link
Contributor

ttnghia commented Apr 20, 2023

Since we have unique_count_column.cu, should unique_count.cu also be renamed to unique_count_table.cu?

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit ac26953 into rapidsai:branch-23.06 Apr 25, 2023
@davidwendt davidwendt deleted the split-unique-count branch April 25, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@vuule vuule vuule approved these changes

@hyperbolic2346 hyperbolic2346 Awaiting requested review from hyperbolic2346 hyperbolic2346 is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidwendt @ttnghia @vyasr @vuule