Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Fix datetime64 related inconsistencies in pytests #13175

Merged
merged 1 commit into from
Apr 20, 2023
Merged

[REVIEW] Fix datetime64 related inconsistencies in pytests #13175

merged 1 commit into from
Apr 20, 2023

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Apr 19, 2023 •
edited
Loading

Description

This PR fixes datetime64 related pytest failures where pandas returns ns time resolutions for quite a lot of cases, i.e., mostly on the IO APIs side.

Fixes 72 pytests:

= 484 failed, 88162 passed, 2044 skipped, 932 xfailed, 165 xpassed in 444.53s (0:07:24) =

On pandas_2.0_feature_branch:

= 556 failed, 88090 passed, 2044 skipped, 932 xfailed, 165 xpassed in 456.49s (0:07:36) =

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Apr 19, 2023
@galipremsagar galipremsagar self-assigned this Apr 19, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner April 19, 2023 22:33
@galipremsagar galipremsagar requested review from isVoid and removed request for a team April 19, 2023 22:33
@galipremsagar galipremsagar mentioned this pull request Apr 19, 2023
Closed
@galipremsagar galipremsagar merged commit 901a971 into rapidsai:pandas_2.0_feature_branch Apr 20, 2023
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galipremsagar @mroeschke