Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Back port #13188 to branch-23.04 #13195

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Back port #13188 to branch-23.04 #13195

merged 1 commit into from
Apr 21, 2023

Conversation

raydouglass
Copy link
Member

Back ports the fix in #13188 to fix v23.04 builds

@sevagh @raydouglass
Avoid skbuild 0.17.2 which affected the cmake -DPython_LIBRARY string (…
def8be2 
…rapidsai#13188)

We see builds are failing in cuDF, possibly because of a missing `-DPython_LIBRARY` string in the CMake command: https://github.com/rapidsai/cudf/actions/runs/4750812902/jobs/8439338686#step:11:861

This may be a result of the scikit-build release 0.17.2: https://github.com/scikit-build/scikit-build/pull/943/files

Authors:
  - Sevag H (https://github.com/sevagh)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: rapidsai#13188
@raydouglass raydouglass requested review from a team as code owners April 21, 2023 14:48
@raydouglass raydouglass requested review from isVoid and charlesbluca and removed request for a team April 21, 2023 14:48
@github-actions github-actions bot added conda Python Affects Python cuDF API. labels Apr 21, 2023
@raydouglass raydouglass added bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API. conda and removed Python Affects Python cuDF API. conda labels Apr 21, 2023
@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function and removed improvement Improvement / enhancement to an existing function labels Apr 21, 2023
@raydouglass raydouglass merged commit 6b21fe2 into rapidsai:branch-23.04 Apr 21, 2023
@raydouglass raydouglass deleted the backport-pr13188-23.04 branch April 21, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@bdice bdice bdice approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@raydouglass @vyasr @bdice @ajschmidt8 @sevagh