Index class deprecation enforcements
#13204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
reviewed
Apr 24, 2023
galipremsagar
changed the title
Index class deprecation enforcements
galipremsagar
added
improvement
galipremsagar
requested review from
isVoid,
charlesbluca and
shwina
and removed request for
a team
vyasr
reviewed
Apr 25, 2023
wence-
reviewed
Apr 26, 2023
galipremsagar
changed the title
Index class deprecation enforcementsIndex class deprecation enforcements
wence-
reviewed
May 17, 2023
| ``` | ||
| Integer, float, or string indexes are all composed of a single column of data. | ||
| Most `GenericIndex` methods are inherited from `Frame`, saving us the trouble of rewriting them. | ||
| Most `Index` methods are inherited from `Frame`, saving us the trouble of rewriting them. |
There was a problem hiding this comment.
Is point 3 below (Index is a factory class) still correct with these changes?
There was a problem hiding this comment.
Good catch. Updated it. Let me know if you think it needs more clarification.
|
@galipremsagar Do any of these fixes need backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Indexrelated deprecations by removingFloat32Index,Float64Index,GenericIndex,Int8Index,Int16Index,Int32Index,Int64Index,StringIndex,UInt8Index,UInt16Index,UInt32Index,UInt64Index.<NA>value representation incase ofstringdtype.This PR also fixes 202 pytests:
= 267 failed, 95670 passed, 2044 skipped, 763 xfailed, 300 xpassed in 442.18s (0:07:22) =On
pandas_2.0_feature_branch:= 469 failed, 95464 passed, 2044 skipped, 763 xfailed, 300 xpassed in 469.26s (0:07:49) =Checklist