-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix string_scalar stream usage in write_json.cu #13212
Merged
rapids-bot
merged 9 commits into
rapidsai:branch-23.06
from
davidwendt:scalar-stream-json-writer
Apr 27, 2023
Merged
Fix string_scalar stream usage in write_json.cu #13212
rapids-bot
merged 9 commits into
rapidsai:branch-23.06
from
davidwendt:scalar-stream-json-writer
Apr 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
Currently a work in progress
libcudf
Affects libcudf (C++/CUDA) code.
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Apr 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Thank you for catching this!
davidwendt
added
3 - Ready for Review
Ready for review by team
and removed
2 - In Progress
Currently a work in progress
labels
Apr 26, 2023
karthikeyann
approved these changes
Apr 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
bdice
approved these changes
Apr 27, 2023
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
improvement
Improvement / enhancement to an existing function
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes stream usage for
cudf::string_scalar
variables used inwrite_json.cu
. The passed-in stream should be used instead of the default stream supplied by thestring_scalar
constructor. Also removed some unused variables. A couple of strings are hardcoded and so these were moved to device code as constants to avoid the host-to-copy that occurs within thestring_scalar
constructor.Checklist