Set the null count in output columns in the CSV reader #13221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuule
added
cuIO
vuule
commented
Apr 25, 2023
| @@ -859,7 +867,7 @@ table_with_metadata read_csv(cudf::io::datasource* source, | |||
| const std::string dblquotechar(2, parse_opts.quotechar); | |||
| std::unique_ptr<column> col = cudf::make_strings_column(*out_buffers[i]._strings, stream); | |||
| out_columns.emplace_back( | |||
| cudf::strings::replace(col->view(), dblquotechar, quotechar, -1, mr)); | |||
| cudf::strings::detail::replace(col->view(), dblquotechar, quotechar, -1, stream, mr)); | |||
There was a problem hiding this comment.
Unrelated change, just noticed that the version that the detail API needs to be used here to ensure that the right stream is used.
vuule
commented
Apr 25, 2023
Comment on lines
+172
to
+173
| CUDF_EXPECTS(col_lhs.null_count() == 0 and col_rhs.null_count() == 0, | ||
| "All elements should be valid"); |
There was a problem hiding this comment.
This is one test that was (kind of) checking the null count. With this additional check, it fails when the null count is incorrect.
davidwendt
approved these changes
Apr 26, 2023
ttnghia
approved these changes
Apr 26, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CSV reader used to keep the null count of the output columns as
UNKNOWN_NULL_COUNT. This has performance implications on further use of these columns.This PR adds a validity counter to convert_csv_to_cudf kernel. This counter is then used to set the correct null count in the columns.
Also added a test that explicitly checks the null counts, as it is never explicitly used in the CSV reader tests.
Checklist