Split up experimental_row_operator_tests.cu to improve its compile time #13382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
|
Build Metrics Report before this change Also ran a PR build compiling just the one file: The split-up result is two files compiling ~25% faster total: |
davidwendt
added
3 - Ready for Review
davidwendt
commented
May 19, 2023
| #include <thrust/sort.h> | ||
| #include <thrust/transform.h> | ||
|
|
||
| template <typename PhysicalElementComparator> |
There was a problem hiding this comment.
This code was moved from experimental_row_operator_tests.cu
ttnghia
reviewed
May 19, 2023
ttnghia
reviewed
May 19, 2023
ttnghia
approved these changes
May 23, 2023
vyasr
approved these changes
May 23, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed the
experimental_row_operator_tests.cubuild time increased significantly in the last few weeks.This PR splits the thrust calls into a separate .cu file. The remaining code is C++ but could not be converted to .cpp because the
row_operators.cuhfiles contain device code that g++ cannot compile.Checklist