Handle some corner-cases in indexing with boolean masks #13402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note, this was discussed as probably wanted for 23.06 at the last cudf meeting; I haven't yet added tests but will do so on Wednesday. |
These must be treated specially and not accidentally converted to integers before indexing. - Closes rapidsai#13015 - Closes rapidsai#13265 - Closes rapidsai#13270
wence-
force-pushed
the
wence/fix/13265-13270
branch
from
ab3c369
to
ae4188d
Compare
wence-
added
improvement
wence-
force-pushed
the
wence/fix/13265-13270
branch
from
428644a
to
163b3fc
Compare
wence-
commented
May 25, 2023
| raise NotImplementedError( | ||
| "Cannot use Series object for mask iloc indexing" | ||
| ) | ||
| # TODO: Doesn't handle on-device columns |
There was a problem hiding this comment.
But the old code didn't either...
shwina
reviewed
May 25, 2023
shwina
approved these changes
May 25, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These must be treated specially and not accidentally converted to integers before indexing.
Introduces tighter guards for loc-based indexing with Series where in some circumstances one must align the indices of the indexed object and the indexer. These now raise NotImplementedError rather than returning incorrect answers.
Checklist