Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use <NA> instead of null to match pandas. #13415

Merged
merged 1 commit into from
May 25, 2023
Merged

Use <NA> instead of null to match pandas. #13415

merged 1 commit into from
May 25, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented May 23, 2023

Description

This PR updates the behavior of one-hot encoding to use <NA> for null values rather than null. This aligns with pandas behavior.

This change is backported from #13174 since it applies to pandas 1.x as well as pandas 2.0.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner May 23, 2023 17:47
@bdice bdice requested review from shwina and charlesbluca May 23, 2023 17:47
@bdice bdice self-assigned this May 23, 2023
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 23, 2023
@bdice
Copy link
Contributor Author

bdice commented May 23, 2023 •
edited
Loading

This PR can target 23.08 but we don't have forward mergers from 23.06 to 23.08 yet and this depends on recent changes on branch-23.06. Once branch-23.08 is up to date, we can move the target branch.

edit: forward mergers were fixed, this can target 23.06 or 23.08 now.

@bdice bdice added improvement Improvement / enhancement to an existing function breaking Breaking change labels May 23, 2023
@bdice
Copy link
Contributor Author

bdice commented May 23, 2023

This changes behavior (column names are different) so I marked it as breaking.

@shwina @galipremsagar Do you think this should go in for 23.06 or 23.08? We have the opportunity to exactly match pandas behavior by merging this (in conjunction with the merged changes from #11656).

@galipremsagar
Copy link
Contributor

This changes behavior (column names are different) so I marked it as breaking.

@shwina @galipremsagar Do you think this should go in for 23.06 or 23.08? We have the opportunity to exactly match pandas behavior by merging this (in conjunction with the merged changes from #11656).

Okay to target for 23.06 since this is a bug fix. But will wait on @shwina to comment too.

@bdice bdice added bug Something isn't working and removed improvement Improvement / enhancement to an existing function labels May 23, 2023
shwina
shwina approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to go ahead and merge

@shwina
Copy link
Contributor

shwina commented May 25, 2023

/merge

1 similar comment
@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 03f0c0c into rapidsai:branch-23.06 May 25, 2023
@bdice bdice deleted the pandas-na-name branch May 25, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwina shwina shwina approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@bdice bdice

Labels
breaking Breaking change bug Something isn't working Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdice @galipremsagar @shwina