Fix cudf::strings::replace_with_backrefs hang on empty match result #13418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
bug
|
@andygrove verified this fixes the bug he reported in #13404 |
GregoryKimball
approved these changes
May 24, 2023
ttnghia
reviewed
May 24, 2023
ttnghia
reviewed
May 24, 2023
ttnghia
approved these changes
May 24, 2023
PointKernel
approved these changes
May 25, 2023
| @@ -61,14 +61,15 @@ struct backrefs_fn { | |||
| auto out_ptr = d_chars ? (d_chars + d_offsets[idx]) : nullptr; | |||
| size_type lpos = 0; // last byte position processed in d_str | |||
| size_type begin = 0; // first character position matching regex | |||
| size_type end = nchars; // last character position (exclusive) | |||
| size_type end = -1; // last character position (exclusive) | |||
There was a problem hiding this comment.
Suggested change
| size_type end = -1; // last character position (exclusive) | |
| size_type end = -1; // last character position |
no longer relevant
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug where the
cudf::strings::replace_with_backrefsgoes into an infinite loop when an match results in an empty string. After each replace occurs, the logic continues to search for matches on the remainder of the string. Each new starting point must account for the previous match being empty.Also included a gtest for this case.
Closes #13404
Checklist