Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sort=True for Index.union, Index.difference and Index.intersection #13497

Merged

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Jun 1, 2023

Description

This PR enables sort=True for union, difference, and intersection APIs in Index.

This also fixes 1 pytest failure and adds 77 pytests:
On Index_sort_2.0:

= 230 failed, 95836 passed, 2045 skipped, 768 xfailed, 308 xpassed in 438.88s (0:07:18) =

On pandas_2.0_feature_branch:

= 231 failed, 95767 passed, 2045 skipped, 764 xfailed, 300 xpassed in 432.59s (0:07:12) =

xref: pandas-dev/pandas#25151

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 1, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner June 1, 2023 20:08
@galipremsagar galipremsagar self-assigned this Jun 1, 2023
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 4 - Needs cuDF (Python) Reviewer labels Jun 2, 2023
@galipremsagar galipremsagar merged commit 139e32d into rapidsai:pandas_2.0_feature_branch Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants