Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable writing column names with mixed dtype in parquet writer when mode.pandas_compatible=True #13505

Merged
merged 7 commits into from
Jun 14, 2023
Merged

Enable writing column names with mixed dtype in parquet writer when mode.pandas_compatible=True #13505

merged 7 commits into from
Jun 14, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

This PR enables writing a dataframe that has column names that are of mixed types to a parquet file when pandas compatibility mode is enabled(mode.pandas_compatible=True).

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 2, 2023
@galipremsagar galipremsagar self-assigned this Jun 2, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner June 2, 2023 19:38
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jun 2, 2023
@galipremsagar galipremsagar mentioned this pull request Jun 2, 2023
Closed
bdice
bdice requested changes Jun 2, 2023
View reviewed changes
python/cudf/cudf/_lib/parquet.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_parquet.py Outdated Show resolved Hide resolved
@galipremsagar galipremsagar requested a review from bdice June 12, 2023 22:38
bdice
bdice requested changes Jun 13, 2023
View reviewed changes
docs/cudf/source/user_guide/pandas-comparison.md Outdated Show resolved Hide resolved
docs/cudf/source/user_guide/pandas-comparison.md Outdated Show resolved Hide resolved
docs/cudf/source/user_guide/pandas-comparison.md Outdated Show resolved Hide resolved
docs/cudf/source/user_guide/pandas-comparison.md Outdated Show resolved Hide resolved
docs/cudf/source/user_guide/pandas-comparison.md Outdated Show resolved Hide resolved
docs/cudf/source/user_guide/pandas-comparison.md Outdated Show resolved Hide resolved
python/cudf/cudf/_lib/parquet.pyx Outdated Show resolved Hide resolved
docs/cudf/source/user_guide/pandas-comparison.md Outdated Show resolved Hide resolved
@galipremsagar @bdice
Apply suggestions from code review
80b1293 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@galipremsagar galipremsagar requested a review from bdice June 13, 2023 14:18
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Jun 14, 2023
@galipremsagar galipremsagar merged commit fb99b0a into rapidsai:pandas_2.0_feature_branch Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@vuule vuule vuule approved these changes

@mroeschke mroeschke Awaiting requested review from mroeschke

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@galipremsagar @bdice @vuule