Upgrade pandas pinnings & make style fixes #13599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
improvement
galipremsagar
requested review from
vyasr and
isVoid
and removed request for
a team
raydouglass
approved these changes
Jun 21, 2023
vyasr
approved these changes
Jun 29, 2023
charlesbluca
approved these changes
Jun 29, 2023
wence-
reviewed
Aug 22, 2023
| @@ -2891,7 +2891,7 @@ def test_rangeindex_join_user_option(default_integer_bitwidth): | |||
| actual = idx1.join(idx2, how="inner", sort=True) | |||
| expected = idx1.to_pandas().join(idx2.to_pandas(), how="inner", sort=True) | |||
| assert actual.dtype == cudf.dtype(f"int{default_integer_bitwidth}") | |||
| assert_eq(expected, actual) | |||
| assert_eq(expected, actual, exact=False) | |||
There was a problem hiding this comment.
Is the exactness not possible because the bitwidth might be different?
| @@ -183,7 +183,9 @@ def test_dataframe_join_suffix(): | |||
| assert_eq(expect.index.values, got.index.values) | |||
|
|
|||
| got_sorted = got.sort_values(by=list(got.columns), axis=0) | |||
| expect.index.name = None | |||
There was a problem hiding this comment.
Is this an API-mismatch in sort_values for us?
|
@galipremsagar do we need to move this PR forward? It looks like #13624 was created just to test this against the latest main branch? |
|
#14918 solves this issues being addressed in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades pandas pinning & fixes style issues in the feature branch.
Checklist