Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate is_datetime64tz_dtype and is_interval_dtype #14275

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Deprecate is_datetime64tz_dtype and is_interval_dtype #14275

merged 2 commits into from
Oct 12, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

This PR deprecates is_datetime64tz_dtype and is_interval_dtype to have parity with pandas-2.x: pandas-dev/pandas#52607, alternatively this PR internalizes these utilities.

This PR:

= 1584 failed, 98570 passed, 2069 skipped, 776 xfailed, 312 xpassed, 20 errors in 737.24s (0:12:17) =

On pandas_2.0_feature_branch:

= 23835 failed, 5698 passed, 1613 skipped, 288 xfailed, 423 errors in 1976.84s (0:32:56) =

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change labels Oct 12, 2023
@galipremsagar galipremsagar self-assigned this Oct 12, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner October 12, 2023 23:14
@galipremsagar galipremsagar requested review from shwina and brandon-b-miller and removed request for a team October 12, 2023 23:14
@github-actions github-actions bot added the Python Affects Python cuDF API. label Oct 12, 2023
mroeschke
mroeschke approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@galipremsagar galipremsagar merged commit 7c6d8f2 into rapidsai:pandas_2.0_feature_branch Oct 12, 2023
16 of 18 checks passed
@galipremsagar galipremsagar mentioned this pull request Oct 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@shwina shwina Awaiting requested review from shwina shwina is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galipremsagar @mroeschke