Introduce Comprehensive Pathological Unit Tests for Issue #14409 #14459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
bdice
reviewed
Nov 21, 2023
bdice
added
improvement
|
/ok to test |
|
@aocsa since this PR isn't detecting any critical issues, could you rebase on branch-24.02? We are no longer making new changes on 23.12 at this stage. |
aocsa
force-pushed
the
fix/issue_14409
branch
from
e12caa1
to
78e7f48
Compare
github-actions
bot
added
Python
vyasr
requested changes
Nov 21, 2023
github-actions
bot
removed
Python
|
/ok to test |
@aocsa I'm not sure what you're asking, but you seem to have already done what's needed! I see that you've rebased your branch on 24.02. The only other thing that was needed was changing the base branch for the PR, which I have done. |
bdice
requested changes
Nov 21, 2023
bdice
approved these changes
Nov 21, 2023
|
/ok to test |
I think this is ready to be merged, right? |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue at #14409. I would like to propose the addition of unit tests that involve scenarios like having 100 or 1000 elements in a tree, reaching 100 levels of depth, with diferent data types and similar stress tests. The purpose of these tests is to conduct comprehensive testing and stress the Abstract Syntax Tree (AST), ultimately aiding in the identification and resolution of any potential issues.
By introducing these pathological tests, we aim to ensure the robustness and reliability of our codebase. These tests can help us uncover edge cases and performance bottlenecks that might otherwise go unnoticed.
Checklist