Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in Series.value_counts #14550

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Fix typo in Series.value_counts #14550

merged 1 commit into from
Dec 5, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

This PR fixes the return type of Series.value_counts to return int64, correcting a typo that was int34.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change labels Dec 4, 2023
@galipremsagar galipremsagar self-assigned this Dec 4, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner December 4, 2023 04:30
@galipremsagar galipremsagar requested review from charlesbluca and removed request for a team December 4, 2023 04:30
@github-actions github-actions bot added the Python Affects Python cuDF API. label Dec 4, 2023
@galipremsagar galipremsagar mentioned this pull request Dec 4, 2023
Closed
wence-
wence- approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to note, I would love to be able to return things of type cudf::size_type here.

mroeschke
mroeschke approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would also be good to have a unit test hitting this path

@galipremsagar
Copy link
Contributor Author

size_type

We do have size_type_dtype = np.dtype("int32") defined but nothing for int64

@galipremsagar
Copy link
Contributor Author

Would also be good to have a unit test hitting this path

Tests were failing already due to this issue, they will now start to pass.

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Dec 5, 2023
@wence-
Copy link
Contributor

wence- commented Dec 5, 2023

size_type

We do have size_type_dtype = np.dtype("int32") defined but nothing for int64

Yeah, I meant that I would love not to have to match pandas and return an int64 when we know int32 (or rather size_type) must suffice

@galipremsagar galipremsagar merged commit a068b10 into rapidsai:pandas_2.0_feature_branch Dec 5, 2023
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

@shwina shwina shwina approved these changes

@mroeschke mroeschke mroeschke approved these changes

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@galipremsagar @wence- @shwina @mroeschke