Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve column ordering in DataFrame.stack #14626

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Preserve column ordering in DataFrame.stack #14626

merged 1 commit into from
Dec 16, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

This PR preserves original column ordering in DataFrame.stack

On pandas_2.0_feature_branch:

= 328 failed, 101111 passed, 2091 skipped, 954 xfailed, 312 xpassed in 1113.40s (0:18:33) =

This PR:

= 316 failed, 101123 passed, 2091 skipped, 954 xfailed, 312 xpassed in 1123.65s (0:18:43) =

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. non-breaking Non-breaking change labels Dec 14, 2023
@galipremsagar galipremsagar self-assigned this Dec 14, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner December 14, 2023 01:39
@galipremsagar galipremsagar requested review from shwina and mroeschke and removed request for a team December 14, 2023 01:39
@galipremsagar galipremsagar changed the title Preseve column ordering in DataFrame.stack Preserve column ordering in DataFrame.stack Dec 14, 2023
@galipremsagar galipremsagar merged commit eea5f10 into rapidsai:pandas_2.0_feature_branch Dec 16, 2023
19 of 22 checks passed
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Dec 16, 2023
@galipremsagar galipremsagar mentioned this pull request Dec 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@shwina shwina Awaiting requested review from shwina shwina is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galipremsagar @mroeschke