Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more validation to MultiIndex.to_frame #14671

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Add more validation to MultiIndex.to_frame #14671

merged 1 commit into from
Dec 27, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

This PR adds validation to name inputs in MultiIndex.to_frame API.

On pandas_2.0_feature_branch:

= 198 failed, 101241 passed, 2091 skipped, 954 xfailed, 312 xpassed in 1098.81s (0:18:18) =

This PR:

= 180 failed, 101247 passed, 2091 skipped, 954 xfailed, 312 xpassed in 1025.07s (0:17:05) =

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. non-breaking Non-breaking change labels Dec 26, 2023
@galipremsagar galipremsagar self-assigned this Dec 26, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner December 26, 2023 04:41
@galipremsagar galipremsagar requested review from mroeschke and charlesbluca and removed request for a team December 26, 2023 04:41
@galipremsagar galipremsagar mentioned this pull request Dec 26, 2023
Closed
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Dec 27, 2023
@galipremsagar galipremsagar merged commit 2b9ab53 into rapidsai:pandas_2.0_feature_branch Dec 27, 2023
18 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galipremsagar @mroeschke