Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ignoring empty objects in concat #14672

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Dec 27, 2023

Description

This PR deprecates ignoring empty objects for dtype calculation in concat.

On pandas_2.0_feature_branch:

= 198 failed, 101241 passed, 2091 skipped, 954 xfailed, 312 xpassed in 1098.81s (0:18:18) =

This PR:

= 179 failed, 101260 passed, 2091 skipped, 954 xfailed, 312 xpassed in 1225.23s (0:20:25) =

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 27, 2023
@galipremsagar galipremsagar self-assigned this Dec 27, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner December 27, 2023 00:54
@galipremsagar galipremsagar requested review from vyasr and removed request for a team December 27, 2023 00:54
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Dec 27, 2023
@galipremsagar galipremsagar merged commit 46ef148 into rapidsai:pandas_2.0_feature_branch Dec 27, 2023
18 of 22 checks passed
galipremsagar added a commit that referenced this pull request Dec 30, 2023
This PR adds warning assertions that were missed in #14672

On `pandas_2.0_feature_branch`:
```
= 110 failed, 101331 passed, 2091 skipped, 952 xfailed, 312 xpassed in 1064.30s (0:17:44) =
```
This PR:
```
= 105 failed, 101336 passed, 2091 skipped, 952 xfailed, 312 xpassed in 1068.90s (0:17:48) =
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants