Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pytest condition to include more warning scenarios #14680

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Fix pytest condition to include more warning scenarios #14680

merged 1 commit into from
Dec 29, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

This PR fixes calculation of cond variable in test_corr1d which will include more cases for warnings. This change fixes, 9 pytest failures.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Dec 29, 2023
@galipremsagar galipremsagar self-assigned this Dec 29, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner December 29, 2023 00:39
@galipremsagar galipremsagar requested review from brandon-b-miller and removed request for a team December 29, 2023 00:39
@galipremsagar galipremsagar mentioned this pull request Dec 29, 2023
Closed
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Dec 29, 2023
@galipremsagar galipremsagar merged commit cb09a39 into rapidsai:pandas_2.0_feature_branch Dec 29, 2023
17 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galipremsagar @mroeschke