Use as_column instead of full #14698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
3 tasks
rjzamora
approved these changes
Feb 26, 2024
vyasr
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
@mroeschke can you verify that full isn't used by cuspatial? Otherwise this LGTM pending resolution of the upstream nvcomp issues. Feel free to merge when those are resolved and CI is passing.
3 tasks
|
Thanks for the reminder. Opened up a PR on the cuspatial side rapidsai/cuspatial#1350 |
|
/merge |
rapids-bot bot
pushed a commit
to rapidsai/cuspatial
that referenced
this pull request
Mar 5, 2024
I have a PR in cudf removing `full` in favor of `as_column` which has equivalent functionality (rapidsai/cudf#14698), so replacing the single usage I found here Authors: - Matthew Roeschke (https://github.com/mroeschke) - Bradley Dice (https://github.com/bdice) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Mark Harris (https://github.com/harrism) - GALI PREM SAGAR (https://github.com/galipremsagar) - Bradley Dice (https://github.com/bdice) URL: #1350
rapids-bot bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Mar 5, 2024
CI is failing because some functions use `cudf.core.column.full` which was recently removed. This PR changes that to a supported constructor. xref: rapidsai/cudf#14698 cc: @mroeschke @galipremsagar Authors: - Bradley Dice (https://github.com/bdice) - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) - Matthew Roeschke (https://github.com/mroeschke) - Dante Gama Dessavre (https://github.com/dantegd) URL: #5794
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to #14689, ensures there's 1 entrypoint to create a column from a scalar.
This builds on #14620
Checklist