-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix benchmarks compatibility with newer pytest-cases #14764
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
2 - In Progress
Currently a work in progress
5 - DO NOT MERGE
Hold off on merging; see PR for details
tests
Unit testing for project
non-breaking
Non-breaking change
and removed
Python
Affects Python cuDF API.
conda
labels
Jan 16, 2024
jameslamb
added
3 - Ready for Review
Ready for review by team
and removed
2 - In Progress
Currently a work in progress
5 - DO NOT MERGE
Hold off on merging; see PR for details
labels
Jan 16, 2024
bdice
reviewed
Jan 16, 2024
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
mroeschke
added
the
improvement
Improvement / enhancement to an existing function
label
Jan 17, 2024
mroeschke
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vyasr
approved these changes
Jan 18, 2024
raydouglass
approved these changes
Jan 18, 2024
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Python
Affects Python cuDF API.
tests
Unit testing for project
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts changes from #14756.
cudf
's tests to be compatible with the latestpytest-cases
(version 3.8.2)pytest-cases>=3.8.2
on that project to be sure older versions aren't usedChecklist
Notes for Reviewers
The fix here was to stop using
pytest-cases
's automatic collection of cases, and to instead explicitly tell it where to look.Per the
pytest_cases.get_all_cases()
docs (docs link)Since there are so few uses of
pytest_cases
in this project, I think explicitly passing module names is preferable to adjusting the repo to work with the new patterns introduced in smarie/python-pytest-cases#320.For clarity, I'm also proposing renaming files that only contain test cases such that they begin with
cases_*
, but this isn't strictly necessary... happy to revert that if you'd like.How I tested this
following CONTRIBUTING.md (click me)
Based on the advice in https://docs.rapids.ai/resources/reproducing-ci/, pointed build scripts at local output directories.
Then re-generated the dependency files.
Then created a conda environment to run tests in and built the library.
conda env create \ --name cudf-dev \ --file ./conda/environments/all_cuda-120_arch-x86_64.yaml source activate cudf-dev ./ci/build.sh libcudf cudf
Then ran the benchmarks, following
cudf/ci/test_python_cudf.sh
Line 30 in 726a7f3
Saw those tests succeed with my changes, and fail like #14712 (comment) without them.
I also tried adding a
raise RuntimeError()
to the test cases in e.g.cases_dataframe.py
, just to convince myself that the benchmark cases were actually being successfully collected and run.