Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parquet Writer: Write non-string columns pandas-compatibility mode only #14899

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Parquet Writer: Write non-string columns pandas-compatibility mode only #14899

merged 2 commits into from
Jan 26, 2024

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Jan 26, 2024 •
edited
Loading

Description

This PR enables writing of non-string columns in parquet writer only in pandas-compatibility mode.

This PR:

= 8 failed, 102249 passed, 2090 skipped, 976 xfailed, 312 xpassed in 1363.59s (0:22:43) =

On pandas_2.0_feature_branch:

= 9 failed, 102247 passed, 2091 skipped, 976 xfailed, 312 xpassed in 1336.47s (0:22:16) =

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer labels Jan 26, 2024
@galipremsagar galipremsagar self-assigned this Jan 26, 2024
@galipremsagar galipremsagar requested a review from a team as a code owner January 26, 2024 12:38
@galipremsagar galipremsagar requested review from wence- and charlesbluca and removed request for a team January 26, 2024 12:38
@galipremsagar galipremsagar mentioned this pull request Jan 26, 2024
Closed
wence-
wence- approved these changes Jan 26, 2024
View reviewed changes
python/cudf/cudf/_lib/utils.pyx Outdated Show resolved Hide resolved
@galipremsagar @wence-
Update utils.pyx
fe5e78f 
Co-authored-by: Lawrence Mitchell <wence@gmx.li>
@galipremsagar galipremsagar merged commit 7d3e72a into rapidsai:pandas_2.0_feature_branch Jan 26, 2024
3 of 5 checks passed
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Python) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@wence- wence- wence- approved these changes

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond bug Something isn't working Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@galipremsagar @wence- @bdice @vyasr