-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement concatenate, lists.explode, merge, sorting, and stream compaction in pylibcudf #15011
Implement concatenate, lists.explode, merge, sorting, and stream compaction in pylibcudf #15011
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! Some minor suggestions
Co-authored-by: Lawrence Mitchell <wence@gmx.li>
/merge |
Is there a reason |
It was removed because it was a completely unused function. It is not replaced by anything. If you need it, though, feel free to copy out the source. It was previously a cdef function, but there's really not much reason for it to be one because it was interacting with purely Python objects (DataFrame/Series/Index) except for the return value. Here's the old code:
That should be replaceable with something like this (up to how you want to handle the truthiness of the index parameter)
Then you can use that in a Cython context relying on Cython's automatic list->vector conversion
|
Description
Contributes to #13921
Checklist