Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sort_values pytest failure with pandas-2.x regression #15092

Merged
merged 5 commits into from
Feb 20, 2024
Merged

Fix sort_values pytest failure with pandas-2.x regression #15092

merged 5 commits into from
Feb 20, 2024

Conversation

galipremsagar
Copy link
Contributor

Description

pandas-2.x seems to have introduced an ordering regression where the index order is not preserved for cases when there is a tie.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Feb 20, 2024
@galipremsagar galipremsagar self-assigned this Feb 20, 2024
@galipremsagar galipremsagar requested a review from a team as a code owner February 20, 2024 17:08
galipremsagar and others added 2 commits February 20, 2024 13:14
@galipremsagar @mroeschke
Update python/cudf/cudf/tests/test_sorting.py
cb2e1e6 
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
@galipremsagar
Merge branch 'branch-24.04' into sort_values_fix
21a368e
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Feb 20, 2024
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit e7a7e48 into rapidsai:branch-24.04 Feb 20, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galipremsagar @mroeschke