Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Series.groupby.shift with a MultiIndex #15098

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Fix Series.groupby.shift with a MultiIndex #15098

merged 3 commits into from
Feb 21, 2024

Conversation

mroeschke
Copy link
Contributor

Description

closes #15087
closes #11259

(The typing annotation is incorrect, but I guess there needs to be a check somewhere to make _copy_type_metadata stricter)

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. non-breaking Non-breaking change labels Feb 21, 2024
@mroeschke mroeschke requested a review from a team as a code owner February 21, 2024 00:51
bdice
bdice approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the test name as noted in my comment, then this is good to go.

@mroeschke @bdice
Update python/cudf/cudf/tests/test_groupby.py
d97da32 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 4948aa2 into rapidsai:branch-24.04 Feb 21, 2024
68 checks passed
@mroeschke mroeschke deleted the bug/gb_shift branch February 21, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
2 participants
@mroeschke @bdice