Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFrame.columns = ... retains RangeIndex & set dtype #15129

Merged
merged 12 commits into from
Mar 6, 2024

Conversation

mroeschke
Copy link
Contributor

@mroeschke mroeschke commented Feb 23, 2024

Description

Also

  • Renamed _set_column_names_like to _set_columns_like (we're not just copying over the names)
  • Set verify=False when building the ColumnAccessor (columns are not modified so no need to check the columns)

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. non-breaking Non-breaking change labels Feb 23, 2024
@mroeschke mroeschke requested a review from a team as a code owner February 23, 2024 22:06
python/cudf/cudf/core/dataframe.py Show resolved Hide resolved
python/cudf/cudf/core/dataframe.py Show resolved Hide resolved
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c299a62 into rapidsai:branch-24.04 Mar 6, 2024
74 checks passed
@mroeschke mroeschke deleted the bug/columns_setting branch March 6, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants